Skip to content

Conversation

@SoucheSouche
Copy link
Collaborator

@SoucheSouche SoucheSouche commented Jul 25, 2025

Checklist

  • Component contains License
  • Component contains README.md
  • Component contains idf_component.yml file with url field defined
  • Component was added to upload job
  • Component was added to build job
  • Optional: Component contains unit tests
  • CI passing

Change description

Please describe your change here

@SoucheSouche SoucheSouche marked this pull request as draft July 25, 2025 14:10
@github-actions github-actions bot changed the title feat(esp_commands): add esp_commands code feat(esp_commands): add esp_commands code (IEC-338) Jul 25, 2025
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 3 times, most recently from 5154826 to a58eaa6 Compare July 31, 2025 08:42
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from a58eaa6 to 7aaddae Compare August 4, 2025 12:44
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 7aaddae to 626c620 Compare August 5, 2025 07:43
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 5 times, most recently from 916dbc7 to 7bb19c4 Compare August 5, 2025 11:46
@SoucheSouche SoucheSouche changed the title feat(esp_commands): add esp_commands code (IEC-338) feat(esp_commands): add esp_commands component (IEC-338) Aug 7, 2025
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 7bb19c4 to cf00766 Compare August 7, 2025 11:51
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 2 times, most recently from 7f8ef19 to 1469d38 Compare August 7, 2025 13:06
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 1469d38 to 19173a7 Compare August 7, 2025 13:50
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from df4b49a to aa5a2ca Compare August 12, 2025 10:20
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from aa5a2ca to 253c3a7 Compare August 12, 2025 10:34
…ed arguments

These arguments include:
- fd to use to output data
- write function to use to output data
- opaque pointer used to pass dynamic context to the command fnuction
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from b8e4ef7 to ed6ded5 Compare October 30, 2025 03:04
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 2 times, most recently from 15e2181 to 561248a Compare November 6, 2025 11:46
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 561248a to f5c3189 Compare November 6, 2025 12:08
Copy link
Collaborator

@ESP-Marius ESP-Marius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me @SoucheSouche, just left some minor comments

@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch 4 times, most recently from 83917b9 to e2ce884 Compare November 10, 2025 09:26
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from e2ce884 to 8c0e035 Compare November 11, 2025 06:58
@SoucheSouche SoucheSouche changed the title feat(esp_commands): add esp_commands component (IEC-338) feat(esp_cli_commands): add esp_cli_commands component (IEC-338) Nov 11, 2025
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from c3194be to 1dcc82b Compare November 11, 2025 09:35
@SoucheSouche SoucheSouche force-pushed the feat/add-command-manager-component branch from 1dcc82b to b47ee2d Compare November 11, 2025 09:39
@SoucheSouche SoucheSouche merged commit af5af74 into espressif:master Nov 11, 2025
85 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants