-
Notifications
You must be signed in to change notification settings - Fork 119
feat(esp_cli_commands): add esp_cli_commands component (IEC-338) #530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
SoucheSouche
merged 10 commits into
espressif:master
from
SoucheSouche:feat/add-command-manager-component
Nov 11, 2025
Merged
feat(esp_cli_commands): add esp_cli_commands component (IEC-338) #530
SoucheSouche
merged 10 commits into
espressif:master
from
SoucheSouche:feat/add-command-manager-component
Nov 11, 2025
+3,617
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5154826 to
a58eaa6
Compare
a58eaa6 to
7aaddae
Compare
7aaddae to
626c620
Compare
916dbc7 to
7bb19c4
Compare
ESP-Marius
reviewed
Aug 7, 2025
ESP-Marius
reviewed
Aug 7, 2025
7bb19c4 to
cf00766
Compare
7f8ef19 to
1469d38
Compare
1469d38 to
19173a7
Compare
df4b49a to
aa5a2ca
Compare
aa5a2ca to
253c3a7
Compare
ESP-Marius
reviewed
Oct 28, 2025
…ed arguments These arguments include: - fd to use to output data - write function to use to output data - opaque pointer used to pass dynamic context to the command fnuction
b8e4ef7 to
ed6ded5
Compare
15e2181 to
561248a
Compare
561248a to
f5c3189
Compare
ESP-Marius
reviewed
Nov 10, 2025
Collaborator
ESP-Marius
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me @SoucheSouche, just left some minor comments
83917b9 to
e2ce884
Compare
ESP-Marius
reviewed
Nov 11, 2025
e2ce884 to
8c0e035
Compare
Draft
6 tasks
c3194be to
1dcc82b
Compare
1dcc82b to
b47ee2d
Compare
ESP-Marius
approved these changes
Nov 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
urlfield definedChange description
Please describe your change here